uranusjr commented on code in PR #32630:
URL: https://github.com/apache/airflow/pull/32630#discussion_r1264883865
##########
airflow/api_connexion/parameters.py:
##########
@@ -125,3 +126,9 @@ def apply_sorting(
else:
order_by = f"{lstriped_orderby} asc"
return query.order_by(text(order_by))
+
+
+def get_query_count(query_stmt: sqlalchemy.sql.selectable.Select, session:
sqlalchemy.orm.Session) -> int:
Review Comment:
So seems like a db optimisation issue. Since this is in a function, adding
the reset seems to have no drawbacks. Perhaps a comment explaining the query
difference would prevent someone coming in and mistakenly assuming the order_by
is superfulous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
