eladkal commented on code in PR #32649:
URL: https://github.com/apache/airflow/pull/32649#discussion_r1265426635


##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -392,8 +393,7 @@ breeze release-management publish-docs \
     --package-filter 'apache-airflow-providers-*' \
     --override-versioned
 
-cd "${AIRFLOW_SITE_DIRECTORY}"

Review Comment:
   If you remove this cd then please remove also the `cd ..` in line 397 



##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -381,6 +381,7 @@ If you have providers as list of provider ids because you 
just released them, yo
 ```
 
 - Copy the documentation to the ``airflow-site`` repository
+- Either provide the ``--airflow-site-directory`` flag or set the env 
variable: ``AIRFLOW_SITE_DIRECTORY``

Review Comment:
   AIRFLOW_SITE_DIRECTORY is always point to site directory it's part of 
release process. I'm not sure what is the value of this line?



##########
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##########
@@ -392,8 +393,7 @@ breeze release-management publish-docs \
     --package-filter 'apache-airflow-providers-*' \
     --override-versioned
 
-cd "${AIRFLOW_SITE_DIRECTORY}"
-breeze release-management add-back-references --airflow-site-directory 
--gen-type providers
+breeze release-management add-back-references --airflow-site-directory 
DIRECTORY --gen-type providers

Review Comment:
   Do you mean to run this command we need to manually replace the DIRECTORY 
key word?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to