ferruzzi commented on PR #32524: URL: https://github.com/apache/airflow/pull/32524#issuecomment-1640697582
For a unit test, I don't think we can really test the connection since that would require spinning up a Collector to connect to. Maybe there is some way to mock the connection and check the protocol it is using? Another idea might be to move [this line](https://github.com/apache/airflow/pull/32524/files#diff-bc07cf67d2d211678aaefd4d99b1e8c6e2c6e26a6987e85c5397ccc78fed47feR400) into a helper method and just test if it returns an "https" string or not? The connection inspection sounds like a much better answer, but the string check would be significantly easier. What do folks think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
