potiuk commented on PR #32669: URL: https://github.com/apache/airflow/pull/32669#issuecomment-1641424590
Applied second round of comments from @jedcunningham. For those who did not try it yet, the nice part of this change (after @jedcunningham comment) is that we can start promoting the "good" pattern of only changing the configuration variables that users actually want to change. Part of the change is to make the ``airflow config list`` much more versatile and useful. The default output will (as it did) contain all the configuration (including currently set variables) in a very simple plain format without extra comments and boilerplate as it used to: <img width="453" alt="Screenshot 2023-07-19 at 07 08 39" src="https://github.com/apache/airflow/assets/595491/ccc2baed-e008-4098-a516-9b2719c78ab2";> But this command is now a bit of "swiss-army-knife" of configuration: <img width="1122" alt="Screenshot 2023-07-19 at 07 09 38" src="https://github.com/apache/airflow/assets/595491/e6c576ea-b64e-4fdd-9859-7669de07d388";> Especially the `--defaults` switch is particularly useful to generate default "production" grade configuration. The configuration will have only the built-in airflow defaults (so it does not include the env variables set locally) and it will contains all the descriptions, and generated corresponding variable name for all the configurations, but all the values are commented out by default - so that user can very selectively only uncomment and change those values they want. We've been promoting this kind of behaviour as a good pattern (only set those values that you want to be changed from defaults) and with such generated config file it is, I think, perfect way of doing it, because the user can see all the descriptions and examples right in the place the values can be edited, but the values are actually commented out, so it requires deliberate effort to change them - and users will easily see which of the values they actually changed. <img width="860" alt="Screenshot 2023-07-19 at 07 16 09" src="https://github.com/apache/airflow/assets/595491/84861e6c-98ea-4053-bcb1-7a1399b67d88";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
