potiuk commented on PR #32690:
URL: https://github.com/apache/airflow/pull/32690#issuecomment-1641722737

   This one is another extracted change from #32604 . I think I found the right 
approach for celery command's help when celery executor is not configured. I 
was terribly annyoyed that I cannot see help command output for celery when 
celery executor was not set. This is quite an anti-patterrn of CLI s to not 
even be able to discover what commands you will be able to use under the 
"celery" if there is no configuration set.
   
   With this change:
   * running help for the commands will only print a warning
   * running the commands will fail
   
   I think it's much better and consistent, and also it has the added advantage 
that the logic and the code for it is present in "celery_command" and not in 
cli_config.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to