potiuk commented on code in PR #32604:
URL: https://github.com/apache/airflow/pull/32604#discussion_r1268176743
##########
airflow/cli/cli_config.py:
##########
@@ -793,6 +814,13 @@ def string_lower_type(val):
action="store_true",
)
+# IMPORTANT NOTE!
+#
+# Celery configs below have explicit fallback values because celery provider
defaults are not yet loaded
+# via provider at the time we parse the command line, so in case it is not
set, we need to have manual
+# fallback
+# DO NOT REMOVE THE FALLBACKS even if you are tempted to.
+# TODO: possibly move the commands to providers but that could be big
performance hit on the CLI
Review Comment:
I have added test/protection to see if there is an accidental usage of
providers manager while running CLI parsing. I think it might be useful once
you will be merging #29055 - see https://github.com/apache/airflow/pull/32694
I think with the right lazy loading approach it should be possible to the
the #29055 as well. But let's see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
