Bowrna commented on code in PR #31996:
URL: https://github.com/apache/airflow/pull/31996#discussion_r1268928907
##########
airflow/jobs/job.py:
##########
@@ -207,7 +207,16 @@ def heartbeat(
self.log.debug("[heartbeat]")
except OperationalError:
Stats.incr(convert_camel_to_snake(self.__class__.__name__) +
"_heartbeat_failure", 1, 1)
- self.log.exception("%s heartbeat got an exception",
self.__class__.__name__)
+ if self.is_alive():
+ self.log.error(
+ "%s heartbeat failed with error. Scheduler may go into
unhealthy state",
+ self.__class__.__name__,
+ )
+ else:
+ self.log.error(
+ "%s heartbeat failed with error. Scheduler is in unhealthy
state", self.__class__.__name__
+ )
Review Comment:
@potiuk I have some questions on this part.
If the scheduler goes to an unhealthy state, I understand it has to be
logged first about that issue with a trace in the dump file. what about
consecutive heart failure if the heartbeat has not recovered? do we have to log
each one of them or just keep a record of the start of the failure? ( If yes,
then I may need to keep a boolean to toggle for knowing if its first time or
anything after that. Am I right? )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
