potiuk commented on code in PR #31996:
URL: https://github.com/apache/airflow/pull/31996#discussion_r1268932956
##########
airflow/jobs/job.py:
##########
@@ -207,7 +207,16 @@ def heartbeat(
self.log.debug("[heartbeat]")
except OperationalError:
Stats.incr(convert_camel_to_snake(self.__class__.__name__) +
"_heartbeat_failure", 1, 1)
- self.log.exception("%s heartbeat got an exception",
self.__class__.__name__)
+ if self.is_alive():
+ self.log.error(
+ "%s heartbeat failed with error. Scheduler may go into
unhealthy state",
+ self.__class__.__name__,
+ )
+ else:
+ self.log.error(
+ "%s heartbeat failed with error. Scheduler is in unhealthy
state", self.__class__.__name__
+ )
Review Comment:
Yeah I think it would be nice to keep some state information to decide what
to log and what to not log and avoid logging consecutive errors. Maybe also
@BShraman might have some ideas and insights/concrete proposals how to improve
this - they seem to achieve similar improvement - opened
https://github.com/apache/airflow/issues/32586 (which i just commented and
closed as duplicate of #31810 ). Looking for those suggestion and discussion on
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
