vincbeck commented on code in PR #32664:
URL: https://github.com/apache/airflow/pull/32664#discussion_r1269600425


##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -796,7 +796,11 @@ def test_connection(self):
         """
         try:
             session = self.get_session()
-            conn_info = session.client("sts").get_caller_identity()
+            test_endpoint_url = 
self.conn_config.extra_config.get("test_endpoint_url")
+            conn_info = session.client(
+                "sts",
+                endpoint_url=test_endpoint_url,

Review Comment:
   Did you tested it when `test_endpoint_url ` is None. My experience with 
`boto3` is they make a difference between a parameter value being `None` and a 
parameter not provided to the function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to