syedahsn commented on code in PR #32513:
URL: https://github.com/apache/airflow/pull/32513#discussion_r1270293579
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -1332,16 +1391,46 @@ def execute(self, context: Context) -> None:
self.log.info("Stopping application: %s", self.application_id)
if self.force_stop:
- self.hook.cancel_running_jobs(
- self.application_id,
- waiter_config={
- "Delay": self.waiter_delay,
- "MaxAttempts": self.waiter_max_attempts,
- },
+ count = self.hook.cancel_running_jobs(
+ application_id=self.application_id,
+ wait_for_completion=False,
)
+ if count > 0:
+ self.log.info("now waiting for the %s cancelled job(s) to
terminate", count)
+ if self.deferrable:
+ self.defer(
+ trigger=EmrServerlessCancelJobsTrigger(
+ application_id=self.application_id,
+ aws_conn_id=self.aws_conn_id,
+ waiter_delay=self.waiter_delay,
+ waiter_max_attempts=self.waiter_max_attempts,
+ ),
+ timeout=timedelta(seconds=self.waiter_max_attempts *
self.waiter_delay),
+ method_name="stop_application",
+ )
+ self.hook.get_waiter("no_job_running").wait(
Review Comment:
I'm not sure what you mean. If `self.deferrable=True`, execution will jump
to `stop_application` after the Trigger is done, so it will not get to
`self.hook.get_waiter("no_job_running").wait()` again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
