BShraman commented on code in PR #31996:
URL: https://github.com/apache/airflow/pull/31996#discussion_r1271659325
##########
airflow/jobs/job.py:
##########
@@ -207,7 +207,16 @@ def heartbeat(
self.log.debug("[heartbeat]")
except OperationalError:
Stats.incr(convert_camel_to_snake(self.__class__.__name__) +
"_heartbeat_failure", 1, 1)
- self.log.exception("%s heartbeat got an exception",
self.__class__.__name__)
+ if self.is_alive():
+ self.log.error(
+ "%s heartbeat failed with error. Scheduler may go into
unhealthy state",
+ self.__class__.__name__,
+ )
+ else:
+ self.log.error(
+ "%s heartbeat failed with error. Scheduler is in unhealthy
state", self.__class__.__name__
+ )
Review Comment:
> Details of the error are available in {THIS_DUMP_FILE} for further
inspection if it repeats often"
I agree with @potiuk's suggestion. It will undoubtedly be beneficial.
However, it would be advantageous to have an option to store this file outside
the scheduler components, for instance, using remote/volume mounts. Otherwise,
if the scheduler is restarted due to a health check, the file will be lost i
guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
