dstandish commented on PR #32820: URL: https://github.com/apache/airflow/pull/32820#issuecomment-1649121550
> The real meaningful change looks pretty straightfoward to me actually. Looking forward to this being cleaned up. Sorry didn't realize there was so much garbage in there from my `wip` commit @uranusjr ... will clean it up... just pushed it quickly cus i didn't know if i'd have time to do a once over before turning in for my evening. Anyway, meanwhile i'll just point out couple things 1. we didn't make the params `is_setup`, `is_teardown` and `on_failure_fail_dagrun` operator params, expecting that users would manage those attrs with the methods / decorator. that is one way in which this is different from other attrs handled by mapping / expand. if it's a concern for you we could make them operator params just for consistency / compatibility 2. the method `as_teardown` is an instance method so that's why it ends up being helpful to be able to change trigger_rule on mappedoperator -- because it's not necessarily determined at time `expand` is called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
