uranusjr commented on code in PR #32716:
URL: https://github.com/apache/airflow/pull/32716#discussion_r1273005115
##########
airflow/models/taskinstance.py:
##########
@@ -1651,16 +1646,23 @@ def signal_handler(signum, frame):
)
# Run pre_execute callback
- self.task.pre_execute(context=context)
+ # Is never MappedOperator at this point
+ self.task.pre_execute(context=context) # type: ignore[union-attr]
Review Comment:
The fact I wrote the code is not a particularly promising guarantee though 😛
But code here is pretty awful. I’ll add a commit to better fix this up later…
##########
airflow/models/taskinstance.py:
##########
@@ -1651,16 +1646,23 @@ def signal_handler(signum, frame):
)
# Run pre_execute callback
- self.task.pre_execute(context=context)
+ # Is never MappedOperator at this point
+ self.task.pre_execute(context=context) # type: ignore[union-attr]
Review Comment:
The fact I wrote the code is not a particularly promising guarantee though 😛
But code here is pretty awful. I’ll add a commit to better fix this up later…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
