potiuk commented on code in PR #32767:
URL: https://github.com/apache/airflow/pull/32767#discussion_r1274012737
##########
airflow/providers/cncf/kubernetes/kubernetes_helper_functions.py:
##########
@@ -43,8 +43,14 @@ def rand_str(num):
return "".join(secrets.choice(alphanum_lower) for _ in range(num))
-def add_pod_suffix(*, pod_name, rand_len=8, max_len=80):
- """Add random string to pod name while staying under max len."""
+def add_pod_suffix(pod_name: str, rand_len: int = 8, max_len: int = 80) -> str:
Review Comment:
I added it back. When I did it, MyPy started to report another error which
made completely no sense:
<img width="577" alt="Screenshot 2023-07-25 at 21 46 30"
src="https://github.com/apache/airflow/assets/595491/8dd7a9e3-94b0-4a08-89fb-b8e1e6340c53";>
So I had to type-ignore it. But it seems to work after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
