amoghrajesh commented on code in PR #32719:
URL: https://github.com/apache/airflow/pull/32719#discussion_r1275173011
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -353,7 +354,7 @@ def __init__(
self.volumes = [convert_volume(volume) for volume in volumes] if
volumes else []
self.secrets = secrets or []
self.in_cluster = in_cluster
- self.cluster_context = cluster_context
+ self.cluster_context = cluster_context or ""
Review Comment:
Is this the right syntax? It will always evaluate to cluster_context.
Python will perform an 'or' operation here.
You should rather do:
`self.cluster_context = cluster_context if cluster_context else ""`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
