uranusjr commented on code in PR #32838:
URL: https://github.com/apache/airflow/pull/32838#discussion_r1275448579
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -42,6 +43,16 @@ def get_user_name(self) -> str:
"""Return the username associated to the user in session."""
...
+ @abstractmethod
+ def get_user(self) -> BaseUser:
+ """Return the user associated to the user in session."""
+ ...
+
+ @abstractmethod
+ def get_user_id(self) -> str:
+ """Return the user ID associated to the user in session."""
+ ...
Review Comment:
Then do we want to do a `str()` cast in the subclass so it actually returns
a str? Right now I think the returned value would be an int and not match the
annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
