pierrejeambrun opened a new pull request, #32887: URL: https://github.com/apache/airflow/pull/32887
Fix wrong usage of nullable prop next to a ref. TLDR $ref should have sibling. (unless OpenAPI 3.1 that allows description and summary only I believe). This induce wrong api documentation and most importantly bugs in our python clients such as: - https://github.com/apache/airflow-client-python/commit/ddd6fc0545a8066f474c765e1644a5202eebd256 That needs to be manually cherry picked on each new release. - https://github.com/apache/airflow-client-python/pull/89 another occurence that we forgot to also manually patch post client generation.- This allows to generate the expected api doc and the correct client. I Tried that locally by regenerating the client and making the problematic call, such as: ``` # The one that cancelled 2.6.2rc1 client. dag_api_instance.get_tasks(DAG_ID) ``` It is working with this spec. After this we can: - Update the client release process to remove the cherry picking part. (manual fix) - Close https://github.com/apache/airflow-client-python/pull/89 - Add a pre-commit hook to prevent siblings on $ref elements. (check why the current spec validator wrongfully allows it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
