ashwaq06 commented on code in PR #32915:
URL: https://github.com/apache/airflow/pull/32915#discussion_r1277997585
##########
airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -144,7 +144,7 @@ def _build_unload_query(
self, credentials_block: str, select_query: str, s3_key: str,
unload_options: str
) -> str:
return f"""
- UNLOAD ('{select_query}')
+ UNLOAD ($${select_query}$$)
Review Comment:
Thank you for raising this concern. @vincbeck is correct that queries using
double quotes might not work as expected with the current change. To address
this, we can enhance the implementation to detect if the string uses double
quotes, and in such cases, skip the use of `$$`. This way, we ensure
compatibility for both single and double quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
