Adaverse commented on code in PR #32810:
URL: https://github.com/apache/airflow/pull/32810#discussion_r1278001774


##########
airflow/cli/cli_config.py:
##########
@@ -1721,6 +1747,12 @@ class GroupCommand(NamedTuple):
         
func=lazy_load_command("airflow.cli.commands.db_command.drop_archived"),
         args=(ARG_DB_TABLES, ARG_YES),
     ),
+    ActionCommand(

Review Comment:
   There are few places where `initdb` from `airflow.utils.db` is being called 
that creates default connection ex - 
   
https://github.com/apache/airflow/blob/f91c003092e0e2c0e5b9a5073352b023a51a887f/airflow/utils/db.py#L1669-L1670
   
   
https://github.com/apache/airflow/blob/f91c003092e0e2c0e5b9a5073352b023a51a887f/airflow/utils/db.py#L845-L848
   
   Shall we replace these now with `upgradedb` or maybe in later commits when 
we would have added the desired functionality to `create_default_connections`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to