o-nikolas commented on PR #29055: URL: https://github.com/apache/airflow/pull/29055#issuecomment-1656285496
> BTW. I really like how it makes the core even more "lean" without provider's discovery. That's really good observation that we ONLY need chosen executor's command set and "other's" are not needed. :smiley: > BTW2. You will also have to handle conditional imports of the `cli_config` which apparently was not present in Airflow 2.4. This is a bit unneeded because the _executor* classes are going to be only used in Airflow 2.7, so maybe the best way to handle that would be to exclude them from the import check we do when verifying provider's 2.4 compatibility. > > The easiest way to handle it @o-nikolas - is to try/except Import error the imports and check if airfow version is < 2.7.0 and raise `AirflowOptionalProviderFeatureException`. The `AirflowOptionalProviderFeatureException` is ignored when we verify if providers are OK for old versions of airflow. Okay, I'll try whip this up today. What message should we add in the `AirflowOptionalProviderFeatureException`? Or is this really only for our import checks and is unlikely to be hit by a user? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
