hussein-awala commented on code in PR #32919:
URL: https://github.com/apache/airflow/pull/32919#discussion_r1278101024
##########
airflow/providers/slack/operators/slack_webhook.py:
##########
@@ -169,6 +169,6 @@ def execute(self, context: Context) -> None:
username=self.username,
icon_emoji=self.icon_emoji,
icon_url=self.icon_url,
- # Unused Parameters, if not None than warn user
- link_names=self.link_names,
+ # Unused Parameters, warn user if not None
+ **({"link_names": self.link_names} if self.link_names else {}),
Review Comment:
could you add a unit test to ensure that the argument is not provided when
it's None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
