eladkal commented on code in PR #32869: URL: https://github.com/apache/airflow/pull/32869#discussion_r1278261800
########## airflow/providers/amazon/aws/hooks/eventbridge.py: ########## @@ -16,12 +16,75 @@ # under the License. from __future__ import annotations +import json + from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook +from airflow.providers.amazon.aws.utils import trim_none_values + + +def validate_json(pattern: str) -> None: Review Comment: lets mark private? We might move this one to utils in the future so till we decide how helper functions are organized I think it's best to set them as private to avoid deprecation cycle in the future. ```suggestion def _validate_json(pattern: str) -> None: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
