ashb commented on a change in pull request #5668: [AIRFLOW-5055] support
setting kubernetes_environment_variables config section from env var
URL: https://github.com/apache/airflow/pull/5668#discussion_r310034100
##########
File path: tests/core.py
##########
@@ -795,26 +795,26 @@ def test_parameterized_config_gen(self):
self.assertNotIn("{FERNET_KEY}", cfg)
def test_config_use_original_when_original_and_fallback_are_present(self):
- self.assertTrue(configuration.conf.has_option("core", "FERNET_KEY"))
- self.assertFalse(configuration.conf.has_option("core",
"FERNET_KEY_CMD"))
+ self.assertTrue(configuration.conf.has_option("core", "fernet_key"))
+ self.assertFalse(configuration.conf.has_option("core",
"fernet_key_cmd"))
Review comment:
None of these changes _should_ be needed here, and the tests should pass
without, as this is how we read config values from the `airflow.*` modules, so
for the sake of a smaller change we should revert all these case changes in
tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
