potiuk commented on issue #27932: URL: https://github.com/apache/airflow/issues/27932#issuecomment-1657100955
Hey @o-nikolas (cc: @eladkal). I realized there is one more thing to do after https://github.com/apache/airflow/pull/29055 : making sure our documentation describes the CLI commands in each executor. Currently in https://github.com/apache/airflow/blob/main/docs/apache-airflow/cli-and-env-variables-ref.rst we are using sphinx-argparse to generate list of commands, but once we moved the celery and kubernetes commands to the executors, we also need to move documentation for those commands there as well - in a very similar way I've moved documentation for configuration https://github.com/apache/airflow/pull/32604/files#diff-b9c256e60460840fb031abc0daa8cb160175593ac03b358c426fc35f9ed4f3f0 This is a documentation only, so this is not a blocker to release providers. We still have time to get it implemented in main for 2.7.0 and we can later apply it on top of the provider TAG and rebuild/upload the documentation for celery and kubernetes. How I imagine it, there should be a section where we list all the providers that have executors with some commands added, and have links to the new "CLI" pages where those providers display the args (also done via sphinx-argparse - but only using the commands returned by the executors. I think we have all that we need for that, the provider.yaml files already have optional "executors" dictionary - listing all executors that can contribute the commands (some de-duplication will be needed because for example Celery and CeleryKubernetes contribute the same commands). We could instantiate those args and pass them to sphinx-argparse to generate the documentation. Happy to help @o-nikolas if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
