This is an automated email from the ASF dual-hosted git repository.
mobuchowski pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new f9cddf332d openlineage,gcs: use proper name for openlineage methods
(#32956)
f9cddf332d is described below
commit f9cddf332db712ce2121d355dd94c78b392a7bb9
Author: Maciej Obuchowski <[email protected]>
AuthorDate: Mon Jul 31 14:39:27 2023 +0200
openlineage,gcs: use proper name for openlineage methods (#32956)
Signed-off-by: Maciej Obuchowski <[email protected]>
---
airflow/providers/google/cloud/transfers/gcs_to_gcs.py | 2 +-
docs/apache-airflow-providers-openlineage/guides/developer.rst | 2 +-
tests/providers/google/cloud/transfers/test_gcs_to_gcs.py | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/airflow/providers/google/cloud/transfers/gcs_to_gcs.py
b/airflow/providers/google/cloud/transfers/gcs_to_gcs.py
index cf4cf3c0ce..d4c3bd679f 100644
--- a/airflow/providers/google/cloud/transfers/gcs_to_gcs.py
+++ b/airflow/providers/google/cloud/transfers/gcs_to_gcs.py
@@ -553,7 +553,7 @@ class GCSToGCSOperator(BaseOperator):
if self.move_object:
hook.delete(self.source_bucket, source_object)
- def get_openlineage_events_on_complete(self, task_instance):
+ def get_openlineage_facets_on_complete(self, task_instance):
"""
Implementing _on_complete because execute method does preprocessing on
internals.
This means we won't have to normalize self.source_object and
self.source_objects,
diff --git a/docs/apache-airflow-providers-openlineage/guides/developer.rst
b/docs/apache-airflow-providers-openlineage/guides/developer.rst
index 364f004830..4d5f7a5c67 100644
--- a/docs/apache-airflow-providers-openlineage/guides/developer.rst
+++ b/docs/apache-airflow-providers-openlineage/guides/developer.rst
@@ -81,7 +81,7 @@ Here's example of properly implemented
``get_openlineage_facets_on_complete`` me
.. code-block::
- def get_openlineage_events_on_complete(self, task_instance):
+ def get_openlineage_facets_on_complete(self, task_instance):
"""
Implementing _on_complete because execute method does preprocessing on
internals.
This means we won't have to normalize self.source_object and
self.source_objects,
diff --git a/tests/providers/google/cloud/transfers/test_gcs_to_gcs.py
b/tests/providers/google/cloud/transfers/test_gcs_to_gcs.py
index cf525235b1..f961038f5d 100644
--- a/tests/providers/google/cloud/transfers/test_gcs_to_gcs.py
+++ b/tests/providers/google/cloud/transfers/test_gcs_to_gcs.py
@@ -840,7 +840,7 @@ class TestGoogleCloudStorageToCloudStorageOperator:
operator.execute(None)
- lineage = operator.get_openlineage_events_on_complete(None)
+ lineage = operator.get_openlineage_facets_on_complete(None)
assert len(lineage.inputs) == 1
assert len(lineage.outputs) == 1
assert lineage.inputs[0] == Dataset(
@@ -862,7 +862,7 @@ class TestGoogleCloudStorageToCloudStorageOperator:
operator.execute(None)
- lineage = operator.get_openlineage_events_on_complete(None)
+ lineage = operator.get_openlineage_facets_on_complete(None)
assert len(lineage.inputs) == 3
assert len(lineage.outputs) == 1
assert lineage.inputs == [
@@ -889,7 +889,7 @@ class TestGoogleCloudStorageToCloudStorageOperator:
operator.execute(None)
- lineage = operator.get_openlineage_events_on_complete(None)
+ lineage = operator.get_openlineage_facets_on_complete(None)
assert len(lineage.inputs) == 2
assert len(lineage.outputs) == 2
assert lineage.inputs == [
