Fokko commented on code in PR #32786: URL: https://github.com/apache/airflow/pull/32786#discussion_r1279310404
########## airflow/providers/tabular/sensors/tabular.py: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from datetime import datetime +from typing import TYPE_CHECKING + +from airflow.providers.tabular.hooks.tabular import TabularHook +from airflow.sensors.base import BaseSensorOperator + +if TYPE_CHECKING: + from airflow.utils.context import Context + +PROPERTY_KEY_VTTS = "kafka.connect.vtts" + + +class TabularVttsSensor(BaseSensorOperator): + """ + Sensor to block on tables written by the Kafka Connect to Iceberg sink. + + https://github.com/tabular-io/iceberg-kafka-connect + + Every Iceberg commit performed by the sink includes some snapshot + summary properties. As mentioned above, one such property is the + control topic offsets. Another is the unique UUID assigned to every + commit. Finally, there is a VTTS (valid-through timestamp) property + indicating through what timestamp records have been fully processed, + i.e. all records processed from then on will have a timestamp greater + than the VTTS. This is calculated by taking the maximum timestamp of + records processed from each topic partition, and taking the minimum of + these. If any partitions were not processed as part of the commit then + the VTTS is not set. + """ + + def __init__( + self, + *, + identifier: str, + tabular_conn_id: str = "tabular_default", + num_snapshots: int = 10, + **kwargs, + ) -> None: + super().__init__(**kwargs) + self.identifier = identifier + self.tabular_conn_id = tabular_conn_id + self.num_snapshots = num_snapshots + + def poke(self, context: Context) -> bool: + """ + Pokes until the job has successfully finished. + + :param context: The task context during execution. + :return: True if it succeeded and False if not. + """ + hook = TabularHook(tabular_conn_id=self.tabular_conn_id) Review Comment: I like it, thanks for the suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
