vincbeck commented on PR #32955: URL: https://github.com/apache/airflow/pull/32955#issuecomment-1658579464
Overall I am good with this change. I like it. I would just move it to its own file and not be part of the S3 hook file. Also I am not sure about the `test_connection` method. This method is suppose to return the couple `(status, message)`, here nothing is returned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
