[GitHub] [airflow] Adaverse commented on a diff in pull request #32810: Rename `db upgrade` to `db migrate` and add `connections create-default-connections`

Mon, 31 Jul 2023 12:45:13 -0700 


Adaverse commented on code in PR #32810:
URL: https://github.com/apache/airflow/pull/32810#discussion_r1279807909


##########
airflow/cli/cli_parser.py:
##########
@@ -137,9 +137,12 @@ def get_long_option(arg: Arg):
 
 
 def _add_command(subparsers: argparse._SubParsersAction, sub: CLICommand) -> 
None:
-    sub_proc = subparsers.add_parser(
-        sub.name, help=sub.help, description=sub.description or sub.help, 
epilog=sub.epilog
-    )
+    if isinstance(sub, ActionCommand) and sub.hide:
+        sub_proc = subparsers.add_parser(sub.name, epilog=sub.epilog)

Review Comment:
   Nope, they do get all the args (only help is hidden) --
   
![image](https://github.com/apache/airflow/assets/35839624/3eadeeb2-0e05-43f0-9f3f-2923f4dde74e)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to