ephraimbuddy commented on PR #32102:
URL: https://github.com/apache/airflow/pull/32102#issuecomment-1660011941

   > > I'd suggest using the reload_on_plugin_change to toggle the --preload. 
What do you think @potiuk
   > 
   > Sure, if you think it's fine - but it will bring the previous behaviour if 
`reload_on_plugin_change` is `true` - not sure if the effect of it was 
devastating or just Logs with IntegrityError - this what we are opening to.
   > 
   > If you think It's fine for me - so I won't block it for 2.7.0 - reloading 
on plugin change is useful, and maybe having Integrity check errors is the 
price to pay. Maybe it would be a good idea to add a comment for that option 
that when it is enabled it will (or may? not sure if it happened always) 
produce those kind of errors and this is expected...
   
   Would like to hear what @jedcunningham @dstandish and @ashb think about 
this. I will request the changes back until we have agreed on this. In 
production, it doesn't make sense to reload plugin, so this gives me concern


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to