dstandish commented on code in PR #32985:
URL: https://github.com/apache/airflow/pull/32985#discussion_r1280912529
##########
airflow/models/dag.py:
##########
@@ -2711,6 +2712,7 @@ def add_logger_if_needed(ti: TaskInstance):
secrets_backend_list.insert(0, local_secrets)
execution_date = execution_date or timezone.utcnow()
+ self.validate()
Review Comment:
otherwise we can run `dag.test` on dags that are not valid, that would fail
in real life. i think it's a good thing to have. when adding support here for
fail_stop + is_setup, (and using dag.test for testing) it was a while before i
realized it was explicitly forbidden by validate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
