potiuk commented on PR #33046: URL: https://github.com/apache/airflow/pull/33046#issuecomment-1663674314
I think we rarely have problem with a PR raised from not-rebased code at the beginning. My observation that very rarely people start from an old commit. And even if they do, then "rebase" is very wrong wording. They should `switch` to the latest main, not `rebase`. The `rebase` by definition is when you already have a PR and things changed since you created it, not when you create a new PR - that's why I think adding the checkbox with it here will be mostly noise. We have to be very careful when we add such message we There are two kinds of people (generally): 1) fresh contributors - they open their first PR. Almost by definition they will start from latest main because they just checked out airflow's code. Most of those people will get "please rebase" as part of their journey for the first PR, but they need the advice on rebasing few days or weeks after they created the PR. Informing them about rebase when they create PR is confusing at best and misleading and might lead to more questions (what does it mean? should I click it? I do not understand what they are asking here?) 2) 2nd/3rd-time contributors - those who are **possibly** likely to open a PR from an old commit they had some time ago - most of them already know about rebase as they were informed before. For them creating a PR and seeing the checkbox to click every time is mostly a noise. 3) experienced contributors - this is just noise for them So if anything - I think MAYBE, if we consider improving the experience and inform our contributors better - we should add a message "please keep your PR rebased - and link to the rebase instructions from GitHub in the "first PR" message that is added for users 1) https://github.com/apache/airflow/blob/main/.github/boring-cyborg.yml#L645 - I don't think Pull request template is the right place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
