pankajkoti commented on code in PR #32693:
URL: https://github.com/apache/airflow/pull/32693#discussion_r1283053508


##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1712,7 +1725,10 @@ def _find_zombies(self) -> None:
                 simple_task_instance=SimpleTaskInstance.from_ti(ti),
                 msg=str(zombie_message_details),
             )
-            self.log.error("Detected zombie job: %s", request)
+            # Refer: 
https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/tasks.html#zombie-undead-tasks
+            log_message = f"Detected zombie job: {request}"
+            self.log.error(log_message)

Review Comment:
   We may not need this line as the task_context_logger logs it with the 
self.log object we pass to it. Thus avoiding the need to have multiple 
log.error statements



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to