pankajkoti commented on PR #33040: URL: https://github.com/apache/airflow/pull/33040#issuecomment-1663855708
> FYI: @pankajkoti I think this is a remnant of the distant past where some of the dependencies were limited to the major upper version "just-in-case" - we've since moved from that, right now we generally only limit something when a) we know upcoming major versio will need some effort to convert to (SQLAlchemy for example, FAB etc.) b) we see that it fails our tests in main. > > In both cases the rule we have- described in https://github.com/apache/airflow/blob/main/README.md#approach-to-dependencies-of-airflow says that whenever we upper-bind a dependency - we need to clearly state why in the comment and ideally link to an issue, which keeps track of this condition being solved (so for example when we limit it because of a bug, we should create the issue describing it and when the issue is solved, we should remove the upper-binding). > > This one is clearly from before I introduced the rule and simply needs someone who will take it for a spin and a) get our unit tests pass b) run some smoke tests with Azure. yes, thank you for all the information 🙂 I should have just checked the git blame, did not do that. I think we attempted to unpin those a while ago https://github.com/apache/airflow/pull/29764#issuecomment-1462356933 but saw quite a few failures so we decided to create an issue for this https://github.com/apache/airflow/issues/30199. I tried to link the issue for now against the TODO in https://github.com/apache/airflow/pull/33064 I will check internally if we can try to resolve the issue. Will update on the issue if we're able to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
