amoghrajesh commented on code in PR #33054:
URL: https://github.com/apache/airflow/pull/33054#discussion_r1283105559
##########
airflow/models/baseoperator.py:
##########
@@ -1285,16 +1285,17 @@ def get_task_instances(
"""Get task instances related to this task for a specific date
range."""
from airflow.models import DagRun
- end_date = end_date or timezone.utcnow()
- return session.scalars(
+ query = (
select(TaskInstance)
.join(TaskInstance.dag_run)
.where(TaskInstance.dag_id == self.dag_id)
.where(TaskInstance.task_id == self.task_id)
- .where(DagRun.execution_date >= start_date)
- .where(DagRun.execution_date <= end_date)
- .order_by(DagRun.execution_date)
- ).all()
+ )
+ if start_date:
+ query = query.where(DagRun.execution_date >= start_date)
+ if end_date:
+ query = query.where(DagRun.execution_date <= end_date)
+ return session.scalars(query.order_by(DagRun.execution_date)).all()
Review Comment:
@hussein-awala can we have a test case for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
