o-nikolas commented on code in PR #33089:
URL: https://github.com/apache/airflow/pull/33089#discussion_r1283797073
##########
tests/models/test_trigger.py:
##########
@@ -186,61 +199,11 @@ def test_assign_unassigned(session, create_task_instance):
session.query(Trigger).filter(Trigger.id ==
trigger_on_healthy_triggerer.id).one().triggerer_id
== healthy_triggerer.id
)
-
-
[email protected]("check_triggerer_heartrate", [10, 60, 300])
-def test_assign_unassigned_missing_heartbeat(session, create_task_instance,
check_triggerer_heartrate):
Review Comment:
A new assert was added to the above test that covers the usecase this tests
was trying to cover. This test was quite long and more complicated than I think
required to test this particular code branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
