okayhooni commented on code in PR #33057:
URL: https://github.com/apache/airflow/pull/33057#discussion_r1283901259
##########
tests/providers/cncf/kubernetes/operators/test_pod.py:
##########
@@ -327,7 +327,7 @@ def test_find_pod_labels(self):
self.run_pod(k)
_, kwargs = k.client.list_namespaced_pod.call_args
assert kwargs["label_selector"] == (
- "dag_id=dag,kubernetes_pod_operator=True,run_id=test,task_id=task,"
+
"dag_id=dag,foo=bar,kubernetes_pod_operator=True,run_id=test,task_id=task,"
Review Comment:
Thank you for comment and guide..!
But, I think.. it will be ambiguity between two test cases, when new test
case is added for this.. isn't it..?
- (existing) Test Case 1: test for making label selector logic
- (new) Test Case 2: test for ???...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
