uranusjr commented on code in PR #33130:
URL: https://github.com/apache/airflow/pull/33130#discussion_r1284947606
##########
airflow/providers/amazon/aws/log/s3_task_handler.py:
##########
@@ -122,9 +122,9 @@ def _read_remote_logs(self, ti, try_number, metadata=None)
-> tuple[list[str], l
bucket, prefix =
self.hook.parse_s3_url(s3url=os.path.join(self.remote_base,
worker_log_rel_path))
keys = self.hook.list_keys(bucket_name=bucket, prefix=prefix)
if keys:
- keys = [f"s3://{bucket}/{key}" for key in keys]
- messages.extend(["Found logs in s3:", *[f" * {x}" for x in
sorted(keys)]])
- for key in sorted(keys):
+ keys = sorted(f"s3://{bucket}/{key}" for key in keys)
+ messages.extend(["Found logs in s3:", *[f" * {x}" for x in keys]])
Review Comment:
```suggestion
messages.append("Found logs in s3:")
messages.extend(f" * {x}" for x in keys)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
