eumiro commented on code in PR #33130:
URL: https://github.com/apache/airflow/pull/33130#discussion_r1284973232
##########
scripts/in_container/run_migration_reference.py:
##########
@@ -184,9 +184,9 @@ def ensure_filenames_are_sorted(revisions):
if __name__ == "__main__":
- revisions = list(reversed(list(get_revisions())))
+ revisions = list(reversed(get_revisions()))
Review Comment:
Do we actually have to re-create new `revisions` object three times here?
```python
if __name__ == "__main__":
revisions = get_revisions()
ensure_airflow_version(revisions=reversed(revisions))
ensure_filenames_are_sorted(revisions=reversed(revisions))
update_docs(revisions=revisions)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
