potiuk opened a new pull request, #33136:
URL: https://github.com/apache/airflow/pull/33136
In #32810, "airflow db migrate" command has been added and it is used by
`start-airflow` command. There were a few edge cases not covered and this PR
completes it.
* The "database/load_default_connections" configuration does not need to be
defined any more.
It has no meaning when you use "airflow db migrate" or when you run the new
"airflow connections create-default-connections" commands. So we can now remove
it completely from configuraiton. It will still work in the "airflow db init"
which is deprecated, as long as we provide an explicit fallback. Also if
someone had it defined in their config or env variable, it will continue to
work even if it is not defined.
* We need to explain the change in a significant newsfragment.
* The ``start-airflow`` command supports creating default connections with
``--load-default-connections`` flag. This was lost after the change so this PR
brings it back by running the new "airflow connections
create-default-connections" command if the flag is used.
* The `start-airflow` breeze command can be used to start older versions of
airflow - with ``--use-airflow-version" - those that do not support `airflow db
migrate` command. In this case the old behaviour is used with setting the
"AIRFLOW__DATABASE__LOAD_DEFAULT_CONNECTIONS" based on the flag passed and
running "airflow db init" instead.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
