potiuk commented on code in PR #33143:
URL: https://github.com/apache/airflow/pull/33143#discussion_r1285115308


##########
docs/apache-airflow/cli-and-env-variables-ref.rst:
##########
@@ -34,6 +34,12 @@ development and testing.
     :local:
     :depth: 2
 
+Providers that implement executors might contribute additional commands to the 
CLI. Here are the commands
+contributed by the community providers:
+
+* Celery Executor and related CLI commands: 
:doc:`apache-airflow-providers-celery:cli-ref`
+* Kubernetes Executor and related CLI commands: 
:doc:`apache-airflow-providers-cncf-kubernetes:cli-ref`
+

Review Comment:
   I thought about it and I decided not to - maybe even forever.
   
   Not for now - that's not as straightforward - also because the CLI commands 
can be technically added by different executors (LocalKubernetesExecutor has 
the same commands as KubernetesExecutor and CeleryKubernetesExecutor adds both 
Celery and Kubernetes one) - so we would have to somehow de-duplicate them - 
and it's not obvious how to fully automate that until we have more executors 
that are potentially extending those we already have.
   
   Since those are only "executors" that can add the CLI commands, they will be 
added rarely enough so that we do not have to automatically discover those, I 
think.
   
   But if we see the need in the future we can always add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to