hussein-awala commented on PR #32990: URL: https://github.com/apache/airflow/pull/32990#issuecomment-1666994117
> You are assuming that the defer timeout is always <overall timeout> - <time elapsed since start> but should we assume that? If we want to apply the same logic used in the normal mode for the execution_timeout the answer will be yes. > Should we not permit user to defer for a specified timeout, which is supported by present design? I can remove the deprecation warning and keep the support of custom timeout for the trigger > I believe (or at least i have always assumed) that the overall task timeout has always already been enforced. but the trigger timeout is something different that you may optionally use if you want to put a timeout on the specific deferral. So if I understand correctly, you're simply removing the feature to optionally put a timeout on a deferral. Is that correct? Is it really necessary / desirable? You assumption is not completely correct; there was already a timeout enforced equals to execution_timeout, but: - it starts from the moment when we defer the task and not from the start_date - the task raise a trigger exception when the trigger is timeouted and not task timeout exception (which stop the execution) - the sensor timeout was not respected: it's configured by the parameter timeout in base sensor which stops the current attempt and give the task another change. I thought that we allow the user to define a trigger timeout as a workaround for this case, but it appears that it is not the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
