uranusjr commented on code in PR #33158:
URL: https://github.com/apache/airflow/pull/33158#discussion_r1285418069
##########
airflow/api_connexion/endpoints/pool_endpoint.py:
##########
@@ -124,7 +124,7 @@ def patch_pool(
else:
required_fields = {"name", "slots"}
- fields_diff = required_fields - set(get_json_request_dict().keys())
+ fields_diff = required_fields - set(get_json_request_dict())
Review Comment:
```suggestion
fields_diff = required_fields.difference(get_json_request_dict())
```
##########
airflow/api_connexion/endpoints/pool_endpoint.py:
##########
@@ -139,7 +139,7 @@ def patch_pool(
def post_pool(*, session: Session = NEW_SESSION) -> APIResponse:
"""Create a pool."""
required_fields = {"name", "slots"} # Pool would require both fields in
the post request
- fields_diff = required_fields - set(get_json_request_dict().keys())
+ fields_diff = required_fields - set(get_json_request_dict())
Review Comment:
```suggestion
fields_diff = required_fields.difference(get_json_request_dict())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
