potiuk opened a new pull request, #33171:
URL: https://github.com/apache/airflow/pull/33171
The dnspython and Flask Application Builder have a weird transitive
dependency to openssl. It does not require it - it is an optional dependnency
of email validator that uses dnspython and the dnspython uses pyopenssl when
installed. This is all fine. But when opendns is used with older FAB < 4.1.4)
and NEWER opensl (>=23.0), just creating the FAB applicatio in flask causes an
exception than there is a missing parameter in openssl.
Since openssl is NOT declared as required dependency in neither FAB nor
dnspython, installing airflow with constraints while having a newer version of
pyopenssl does not downgrade pyopenssl it is just mentioned in a conflicting
message resulting from conflicts with other packages already installed (such as
cryptography).
This caused a problem when installin older airflow version in breeze with
--use-airflow-version switch.
Also - during checking this issue, it turned out that we were not
- by default - using the constraints for older version when installing it in
breeze (you could do that by explicitly specifying the constraints). This was
because when you used anoter way to specify versio (commit hash, tag) it is
quite complex to figure out which constraints to use. However we can
automatically derive constraints when you specify version, or branch, which are
the most common scenarios.
This PR fixes the `--use-airflow-version` case for Airflow 2.4 and below by:
* automatically deriving the right constraints when version or branch are
used in `--use-airflow-version`
* adding pyopenssl specifically as dependency when --use-airflow-version
switch is used.
* also a small quality of life improvment - when airflow db migrate fails
(because old versio of airflow does not support it) - we inform the user that
it happened and that we are attempting to run the legacy airflow db init
instead.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
