vchiapaikeo opened a new pull request, #33172:
URL: https://github.com/apache/airflow/pull/33172
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: https://github.com/apache/airflow/issues/32698
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Hoping for some guidance from the community. We occasionally hit DB
deadlocks during the trigger timeout check process. When this happens, the
scheduler crashes. See linked
[issue](https://github.com/apache/airflow/issues/32698) for details. I see two
potential options:
1. Retry these transactions
2. Skip the check entirely and allow another replica or the next timeout
check to run
At first, I was leaning with option 1 but after seeing it in code, I worry
that the retries will cause even more deadlocks. That is, if a user set
AIRFLOW__DATABASE__MAX_DB_RETRIES to a high number (default is 3) and since
AIRFLOW__SCHEDULER__TRIGGER_TIMEOUT_CHECK_INTERVAL already defaults to a very
low number, 15s, this could cause even more stress on the db.
Therefore, going with 2. Please let me know what you think. This should
allow us to avoid crashing the scheduler when deadlocks occur on this
transaction.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
