potiuk commented on PR #33192: URL: https://github.com/apache/airflow/pull/33192#issuecomment-1669380408
As discussed in #33178 - I think this one might hide the problem. `test_mode` is a bad idea to use and I believe #33190 already adds protection against some sqlsessions leaking as side effects from other tests - especially that errors in the test are happening on MySQL, where just mere "opening" of session in a different process could cause the problem. The flaky test connected with "close_all_connections" from #33190 indicate that whatever wrong happens with the session, happens inside the test itself, which looking at the test indicates that it's a real problem and race that might occur in production code. Adding `test_mode" might stop the test from being flaky - but there are few other map-related tests that show similar flakiness and that all leads to a very probable hypothesis that we have a bug in our code that this one might simply hide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
