fgalind1 commented on PR #31066: URL: https://github.com/apache/airflow/pull/31066#issuecomment-1669821395
> When I think of it, I believe there is one more thing needed to get this one in. The end-to-end-tests . > > We already test our helm chart extensively - not only with "helm-tests" but also with "kubernetes_tests". If we add this change without the e2e tests, then we might break things accidentally without knowing it. > > Those are run here: > > [`main`/.github/workflows/ci.yml#L1517](https://github.com/apache/airflow/blob/main/.github/workflows/ci.yml?rgh-link-date=2023-08-07T21%3A14%3A31Z#L1517) > > I think this can be done rather easily: > > 1. extend the GitHub Actions job matrix to add "useStandardNaming" : true/false as parameter > 2. add `--use-starndard-naming` to breeze's `breeze testing k8s` relevant commands and pass the matrix parameter there > > I am happy to help if you are stuck on it @fgalind1, but I think it is a necessary step to keep "useStandardNaming" on-par with the current setting and make sure it will not get broken accidentally in the future. > > It's not very complex, it just needs to dive a bit deeper in Breeze's code that runs k8s, deploy helm charts and run tests on it under the hood. > > You can see the instructions on how to run the E2E tests locally. in [`main`/TESTING.rst#typical-testing-pattern-for-kubernetes-tests](https://github.com/apache/airflow/blob/main/TESTING.rst?rgh-link-date=2023-08-07T21%3A14%3A31Z#typical-testing-pattern-for-kubernetes-tests) and while it might look a bit overwhelming initially, the only thing to do is to make `breeze k8s deploy-airflow` accept the new `--use-standar-naming' flag and later make sure that the same flag used in `breeze k8s run-complete-tests` is propagated down in breeze. > > Happy to help if you are stuck, but the above should be good start. thanks for your reply @potiuk. I've added that new e2e in the next commit https://github.com/apache/airflow/pull/31066/commits/757b88e384b6d40592a9b6dbe28b22053eb528a0 - let me know what you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
