pankajkoti commented on PR #33211: URL: https://github.com/apache/airflow/pull/33211#issuecomment-1670068407
@eladkal I will try giving an attempt to elaborate. While exploring openlineage earlier some time back, we wrote a custom OpenLineage extractor for one of our Asynchronous operators at Astronomer https://github.com/astronomer/astronomer-providers/blob/main/astronomer/providers/google/cloud/extractors/bigquery.py In this module, we were trying to set the sql attribute on the BigQueryInsertJobOperator here: https://github.com/astronomer/astronomer-providers/blob/main/astronomer/providers/google/cloud/extractors/bigquery.py Now since that attribute is redefined to be a property now, while we're trying to assign a value there, it gives an error saying we cannot set it. Here is a test that failed for us while we were testing the RC. https://app.circleci.com/pipelines/github/astronomer/astronomer-providers/6315/workflows/3e9c46a3-ee33-4c58-98cb-1994322af0d7/jobs/42343 Like @mobuchowski suggested, we would need to migrate our extractor to accommodate the changes. But meantime it would help us if we have a backward compatible fix and I think https://github.com/apache/airflow/pull/33218 would help us here with the backward compatibility, otherwise users of this OSS async provider who have enabled OpenLineage extractor for this operator would be affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
