dstandish commented on code in PR #33130:
URL: https://github.com/apache/airflow/pull/33130#discussion_r1287710591
##########
airflow/configuration.py:
##########
@@ -1336,7 +1325,7 @@ def getsection(self, section: str) ->
ConfigOptionsDictType | None:
_section.update(OrderedDict(self.items(section)))
section_prefix = self._env_var_name(section, "")
- for env_var in sorted(os.environ.keys()):
+ for env_var in sorted(os.environ):
Review Comment:
since at least python 3.5, `keys` returns a view of the dict keys, not a new
list, so performance should not be an issue. but using `keys` can provide a
readability benefit, simply by virtue of being explicit. so personally i would
recommend not changing this kind of usage in your other prs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
