dstandish commented on PR #33103: URL: https://github.com/apache/airflow/pull/33103#issuecomment-1670565064
An odd consequence of this is if the task group id is short, we'll actually get a partial name: <img width="945" alt="image" src="https://github.com/apache/airflow/assets/15932138/8e85b069-0a74-492d-ab2d-8ffe0fddb36d";> code to repro: ```python with DAG(dag_id="leaves_ignored", start_date=pendulum.now()): @task def setup1(): ... @task def setup2(): ... @task def teardown1(): ... @task def teardown2(): ... @task def work1(): ... @task def work2(): ... setup1 = setup1() # setup2 = setup2() teardown1 = teardown1() # teardown2 = teardown2() work1 = work1() work2 = work2() with TaskGroup("tg") as tg: setup1 >> work1 >> teardown1 setup1 >> teardown1 tg.add_task(setup1) tg.add_task(teardown1) tg.add_task(work1) tg >> work2 ``` Maybe we should remove `add_task` for task group for now, wdyt @ephraimbuddy @uranusjr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
