uranusjr commented on code in PR #33234:
URL: https://github.com/apache/airflow/pull/33234#discussion_r1288181887
##########
airflow/providers/daskexecutor/executors/dask_executor.py:
##########
@@ -135,13 +135,13 @@ def end(self) -> None:
assert self.client
assert self.futures
- self.client.cancel(list(self.futures.keys()))
+ self.client.cancel(list(self.futures))
for future in as_completed(self.futures.copy()):
self._process_future(future)
def terminate(self):
if TYPE_CHECKING:
assert self.futures
- self.client.cancel(self.futures.keys())
+ self.client.cancel(list(self.futures))
Review Comment:
Hey this might be one of those cases we should use `keys()` instead. (Or can
we just pass in the dict?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
